Tsu Jan [Sun, 21 Apr 2019 19:37:07 +0000 (00:07 +0430)]
Workaround for GLib's recursive moving error, e.g. with bound mounts
`g_file_move()` may not work recursively on the same filesystem, especially
with bound mounts (to `/mnt`, for example) and give the `G_IO_ERROR_WOULD_RECURSE`
error. This patch ignores the error and tries our `FileTransferJob::copyFile()`.
Previously, if a file was in addition queue and then it came into the deletion
queue, its addition and deletion were both ignored. That was wrong and could
result in showing nonexistent files because addition can also happen in
directory list job before being processed by file info job.
Also process accumulated changes only after finishing the current info job and
don't clear all deletion paths after processing them (because, logically, only
those paths that can be deleted should be removed).
Fix the license header of code we took from libfm (they should use LGPL2 instead of GPL2). - src/core/vfs/vfs-menu.c - src/core/vfs/vfs-search.c These files are taken from libfm which has been relicensed to LGPL 2 on 2014-09-05 by Andrey N. Gritsenko after consulting other contributors.
Tsu Jan [Mon, 8 Apr 2019 02:43:09 +0000 (07:13 +0430)]
Fixed SMB recursive copy
Fixes https://github.com/lxqt/libfm-qt/issues/385 by trying to set dir permissions only once and ignoring possible errors (that happen with SMB and, maybe, other protocols).
Tsu Jan [Sun, 21 Apr 2019 19:37:07 +0000 (00:07 +0430)]
Workaround for GLib's recursive moving error, e.g. with bound mounts
`g_file_move()` may not work recursively on the same filesystem, especially
with bound mounts (to `/mnt`, for example) and give the `G_IO_ERROR_WOULD_RECURSE`
error. This patch ignores the error and tries our `FileTransferJob::copyFile()`.
Previously, if a file was in addition queue and then it came into the deletion
queue, its addition and deletion were both ignored. That was wrong and could
result in showing nonexistent files because addition can also happen in
directory list job before being processed by file info job.
Also process accumulated changes only after finishing the current info job and
don't clear all deletion paths after processing them (because, logically, only
those paths that can be deleted should be removed).
Fix the license header of code we took from libfm (they should use LGPL2 instead of GPL2). - src/core/vfs/vfs-menu.c - src/core/vfs/vfs-search.c These files are taken from libfm which has been relicensed to LGPL 2 on 2014-09-05 by Andrey N. Gritsenko after consulting other contributors.
Tsu Jan [Mon, 8 Apr 2019 02:43:09 +0000 (07:13 +0430)]
Fixed SMB recursive copy
Fixes https://github.com/lxqt/libfm-qt/issues/385 by trying to set dir permissions only once and ignoring possible errors (that happen with SMB and, maybe, other protocols).
Tsu Jan [Sun, 21 Apr 2019 19:37:07 +0000 (00:07 +0430)]
Workaround for GLib's recursive moving error, e.g. with bound mounts
`g_file_move()` may not work recursively on the same filesystem, especially
with bound mounts (to `/mnt`, for example) and give the `G_IO_ERROR_WOULD_RECURSE`
error. This patch ignores the error and tries our `FileTransferJob::copyFile()`.
Previously, if a file was in addition queue and then it came into the deletion
queue, its addition and deletion were both ignored. That was wrong and could
result in showing nonexistent files because addition can also happen in
directory list job before being processed by file info job.
Also process accumulated changes only after finishing the current info job and
don't clear all deletion paths after processing them (because, logically, only
those paths that can be deleted should be removed).
Fix the license header of code we took from libfm (they should use LGPL2 instead of GPL2). - src/core/vfs/vfs-menu.c - src/core/vfs/vfs-search.c These files are taken from libfm which has been relicensed to LGPL 2 on 2014-09-05 by Andrey N. Gritsenko after consulting other contributors.
Tsu Jan [Mon, 8 Apr 2019 02:43:09 +0000 (07:13 +0430)]
Fixed SMB recursive copy
Fixes https://github.com/lxqt/libfm-qt/issues/385 by trying to set dir permissions only once and ignoring possible errors (that happen with SMB and, maybe, other protocols).
Tsu Jan [Sun, 21 Apr 2019 19:37:07 +0000 (00:07 +0430)]
Workaround for GLib's recursive moving error, e.g. with bound mounts
`g_file_move()` may not work recursively on the same filesystem, especially
with bound mounts (to `/mnt`, for example) and give the `G_IO_ERROR_WOULD_RECURSE`
error. This patch ignores the error and tries our `FileTransferJob::copyFile()`.
Previously, if a file was in addition queue and then it came into the deletion
queue, its addition and deletion were both ignored. That was wrong and could
result in showing nonexistent files because addition can also happen in
directory list job before being processed by file info job.
Also process accumulated changes only after finishing the current info job and
don't clear all deletion paths after processing them (because, logically, only
those paths that can be deleted should be removed).
Fix the license header of code we took from libfm (they should use LGPL2 instead of GPL2). - src/core/vfs/vfs-menu.c - src/core/vfs/vfs-search.c These files are taken from libfm which has been relicensed to LGPL 2 on 2014-09-05 by Andrey N. Gritsenko after consulting other contributors.
Tsu Jan [Mon, 8 Apr 2019 02:43:09 +0000 (07:13 +0430)]
Fixed SMB recursive copy
Fixes https://github.com/lxqt/libfm-qt/issues/385 by trying to set dir permissions only once and ignoring possible errors (that happen with SMB and, maybe, other protocols).
Tsu Jan [Sun, 21 Apr 2019 19:37:07 +0000 (00:07 +0430)]
Workaround for GLib's recursive moving error, e.g. with bound mounts
`g_file_move()` may not work recursively on the same filesystem, especially
with bound mounts (to `/mnt`, for example) and give the `G_IO_ERROR_WOULD_RECURSE`
error. This patch ignores the error and tries our `FileTransferJob::copyFile()`.
Previously, if a file was in addition queue and then it came into the deletion
queue, its addition and deletion were both ignored. That was wrong and could
result in showing nonexistent files because addition can also happen in
directory list job before being processed by file info job.
Also process accumulated changes only after finishing the current info job and
don't clear all deletion paths after processing them (because, logically, only
those paths that can be deleted should be removed).
Fix the license header of code we took from libfm (they should use LGPL2 instead of GPL2). - src/core/vfs/vfs-menu.c - src/core/vfs/vfs-search.c These files are taken from libfm which has been relicensed to LGPL 2 on 2014-09-05 by Andrey N. Gritsenko after consulting other contributors.
Tsu Jan [Mon, 8 Apr 2019 02:43:09 +0000 (07:13 +0430)]
Fixed SMB recursive copy
Fixes https://github.com/lxqt/libfm-qt/issues/385 by trying to set dir permissions only once and ignoring possible errors (that happen with SMB and, maybe, other protocols).
Previously, if a file was in addition queue and then it came into the deletion
queue, its addition and deletion were both ignored. That was wrong and could
result in showing nonexistent files because addition can also happen in
directory list job before being processed by file info job.
Also process accumulated changes only after finishing the current info job and
don't clear all deletion paths after processing them (because, logically, only
those paths that can be deleted should be removed).
Fix the license header of code we took from libfm (they should use LGPL2 instead of GPL2). - src/core/vfs/vfs-menu.c - src/core/vfs/vfs-search.c These files are taken from libfm which has been relicensed to LGPL 2 on 2014-09-05 by Andrey N. Gritsenko after consulting other contributors.
Tsu Jan [Mon, 8 Apr 2019 02:43:09 +0000 (07:13 +0430)]
Fixed SMB recursive copy
Fixes https://github.com/lxqt/libfm-qt/issues/385 by trying to set dir permissions only once and ignoring possible errors (that happen with SMB and, maybe, other protocols).
Tsu Jan [Mon, 8 Apr 2019 02:43:09 +0000 (07:13 +0430)]
Fixed SMB recursive copy
Fixes https://github.com/lxqt/libfm-qt/issues/385 by trying to set dir permissions only once and ignoring possible errors (that happen with SMB and, maybe, other protocols).
Tsu Jan [Sun, 27 Jan 2019 03:43:38 +0000 (07:13 +0330)]
Added missing sort-by-group action
This is related to https://github.com/lxqt/pcmanfm-qt/issues/886 and will be followed by a pcmanfm-qt patch, which should be applied immediately after it (otherwie, a crash will happen).
Alf Gaida [Tue, 29 Jan 2019 17:20:07 +0000 (18:20 +0100)]
Make setting trust possible anytime
If a file is executable the option should be available in the context menu.
The part
&& (!fileLauncher_ || !fileLauncher_->quickExec()) is superfluous in that case.
projects / libfm-qt.git / log